Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw is evil #9

Merged
merged 3 commits into from Apr 24, 2012
Merged

throw is evil #9

merged 3 commits into from Apr 24, 2012

Conversation

lwille
Copy link
Contributor

@lwille lwille commented Mar 1, 2012

cf. #8

@ecto
Copy link
Owner

ecto commented Mar 2, 2012

I really agree with this. However, I think it should still throw if you haven't provided an error handler. Could you append a commit that adds this functionality?

Thanks for your PR man 😄

@lwille
Copy link
Contributor Author

lwille commented Mar 14, 2012

the "throw" way (not recommended, as there's no way to catch the error):

board = new duino.Board();

the "event" way:

board = new duino.Board();
board.on('error', function(error){console.error(error)});

@richkzad
Copy link
Contributor

richkzad commented Apr 3, 2012

I just ran into this issue too. I have a project that has an optional Arduino component, and if it's not there the project should still keep going.

Would be nice to have this in!

@henvic
Copy link

henvic commented Apr 20, 2012

Hi @ecto, are you going to accept this pull request?

I've just tested and it seems okay.

ecto pushed a commit that referenced this pull request Apr 24, 2012
@ecto ecto merged commit 299f1b4 into ecto:master Apr 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants