-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified settings-template.py
.
Please update README.md
to match the changes
Also, did you install any modules for the concurrent.futures? If so, please run pip freeze > requirements.txt You'll also need to pull the latest changes from the repo first if this is the case |
|
That's fine except for flake8. |
What command did you use to include flake8? |
Ready for second round of review. |
I think set the default concurrent streams to 4 for people on WiFi (both in the template and README) |
README.md
Outdated
@@ -14,6 +14,7 @@ Then, open it in your editor of your choice, and set the following 3 variables: | |||
username = "Your username" # The username you would usually use for My Manchester | |||
password = "Your password" # The accompanying password | |||
base_dir = "~/Documents/Lectures" # Where to download files to | |||
concurrent_downloads = 8 # How many podcasts to download concurrently (Increases speed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use simultaneously instead of concurrently for the description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concurrent is the correct term here, as the downloads are overlapping over a period of time, whereas simultaneously refers to a occurring at the same instant.
Default lowered. |
Yes, but most people don't know what concurrent means, whereas simultaneous
makes more sense for normal people
…On Sun, 12 May 2019, 11:31 Chandler Newman, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#1 (comment)>
:
> @@ -14,6 +14,7 @@ Then, open it in your editor of your choice, and set the following 3 variables:
username = "Your username" # The username you would usually use for My Manchester
password = "Your password" # The accompanying password
base_dir = "~/Documents/Lectures" # Where to download files to
+concurrent_downloads = 8 # How many podcasts to download concurrently (Increases speed)
Concurrent is the correct term here, as the downloads are overlapping over
a period of time, whereas simultaneously refers to a occurring at the same
instant.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADLRGHST3KBPEQ4XSA7X5ADPU7WWXANCNFSM4HMIOWMQ>
.
|
In that case, they will not mess with the setting. We can link to a dictionary or StackOverflow post explaining the meaning if it becomes an issue. |
I held a democratic poll at brunch and the results were:
Simultaneous - 5
Concurrent - 0
…On Sun, 12 May 2019, 12:05 Chandler Newman, ***@***.***> wrote:
Yes, but most people don't know what concurrent means, whereas
simultaneous makes more sense for normal people
In that case, they will not mess with the setting. We can link to a
dictionary or StackOverflow post explaining the meaning if it becomes an
issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADLRGHQPXZU6H4NV5WHL2MDPU72X7ANCNFSM4HMIOWMQ>
.
|
I sadly do not accept democracy and ran a second referendum on this issue: |
Fine, I concede.
Now add a link to the definition in the readme.
…On Sun, 12 May 2019, 12:10 Chandler Newman, ***@***.***> wrote:
I held a democratic poll at brunch and the results were: Simultaneous - 5
Concurrent - 0
I sadly do not accept democracy and ran a second referendum on this issue:
Simultaneous = -5
Concurrent = +10000
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADLRGHSFOOSPXUTF7IJHJFTPU73KPANCNFSM4HMIOWMQ>
.
|
Where would you suggest the link being placed. As it is not possible to have a link inside a code fragment |
How about after the code fragment? I was thinking having a whole paragraph dedicated to explaining the meaning of concurrency and why they are so much more than simultaneous downloads. |
A peer reviewed paper might be the only solution to that problem. However in the meantime, the wording has been changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Download speed seems to be limited per request, not per IP or user.
This enables much faster downloading.