Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Battle calculations are wrong #26

Closed
hugoguercio opened this issue Jul 31, 2021 · 3 comments
Closed

Battle calculations are wrong #26

hugoguercio opened this issue Jul 31, 2021 · 3 comments

Comments

@hugoguercio
Copy link

The battle calculations are wrong, probably not taking into account the elements properly.

image

It says the chances are higher with same monster power but one of them is of weak element !
@arvi0731 arvi0731 mentioned this issue Aug 1, 2021
Merged
@ed3ath
Copy link
Owner

ed3ath commented Aug 1, 2021

chance percentage is based on the min/max power of the enemy compared to yours (already with the element bonus)

please refer to the official formula https://github.com/CryptoBlades/cryptoblades/blob/c80a2215dce034b8356a3e0a7bc9105ded259a6a/frontend/src/views/Combat.vue#L227

@ed3ath
Copy link
Owner

ed3ath commented Aug 1, 2021

I have merged your PR.

@ed3ath ed3ath closed this as completed Aug 1, 2021
@arvi0731
Copy link

arvi0731 commented Aug 1, 2021

I have merged your PR.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hugoguercio @arvi0731 @ed3ath