Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Graph data", "Plot" and "Image" #359

Closed
joncison opened this issue Jun 26, 2018 · 3 comments
Closed

"Graph data", "Plot" and "Image" #359

joncison opened this issue Jun 26, 2018 · 3 comments
Assignees
Labels
concept/term addition Request for a new concept(s), or change(s) to existing concept(s) fixed - released A verified change that has been released question Further information is requested
Milestone

Comments

@joncison
Copy link
Contributor

joncison commented Jun 26, 2018

Graph data is required by DSEO (https://docs.google.com/spreadsheets/d/1ix1eKplAX9KHbBsA6uU7G95_7lD5Q9jGfEL_LV7dYAQ/edit#gid=1477753083) and we have Graph format (http://edamontology.org/format_3617) so I propose it's added: do you agree?

And what to do about Plot (http://edamontology.org/data_2884), this is just a type of Image (http://edamontology.org/data_2968) right?

@joncison joncison added question Further information is requested concept/term addition Request for a new concept(s), or change(s) to existing concept(s) labels Jun 26, 2018
@veitveit
Copy link

If considered as Data, then Graph data could be handled by Pathway or Network (at least broadly).

Image and Plot are quite tricky. An Image could also be a photograph (e.g. of a cell through the microscope). A Plot is a mostly computer-generated figure. So being a child of Image should be OK unless there are other abstract formats of Plot that do not necessary display on the screen or paper. If we consider computational instructions to plot an image (e.g. in Latex) an Image, then this should be fine?

@joncison
Copy link
Contributor Author

I think Plot is a thing that's been rendered (on screen, paper, papyrus scroll etc.).

An Image I don't think can be Computational instructions.

To be more practical / usable, I lean towards broadening the Plot definition to say it can cover plotting instructions - in which case it stays where it is. The alternative would be to say that it is purely an image / figure (in which case it could be moved under Image.

@veitveit
Copy link

+1

@joncison joncison self-assigned this Dec 9, 2018
@joncison joncison added the done - staged for release Done, will appear in the next stable release label Dec 9, 2018
joncison added a commit that referenced this issue Dec 9, 2018
@joncison joncison added this to the 1.22 milestone Mar 28, 2019
@matuskalas matuskalas added fixed - released A verified change that has been released and removed done - staged for release Done, will appear in the next stable release labels May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concept/term addition Request for a new concept(s), or change(s) to existing concept(s) fixed - released A verified change that has been released question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants