Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning level #45

Closed
marehr opened this issue Nov 15, 2016 · 5 comments
Closed

Raise warning level #45

marehr opened this issue Nov 15, 2016 · 5 comments

Comments

@marehr
Copy link
Contributor

marehr commented Nov 15, 2016

Hi,

I would suggest to raise the warning level of the library.

We use the following warning level

  • gcc + icc: -W -Wall -pedantic -fstrict-aliasing -Wstrict-aliasing
  • clang: -W -Wall -pedantic -fstrict-aliasing -Wstrict-aliasing -Wshorten-64-to-32
  • msvc: /W2, but would like to use /W3

Best regards!

@marehr
Copy link
Contributor Author

marehr commented Nov 16, 2016

Thank you for your progress, I rebuild our library and got on clang:

/home/marehr/develope/seqan-src/include/umesimd/plugins/avx512/uint/UMESimdVecUint32_4.h:945:21: warning: unused variable 't0' [-Wunused-variable]
            __m128i t0 = _mm_set1_epi32(b);
                    ^
/home/marehr/develope/seqan-src/include/umesimd/plugins/avx512/int/UMESimdVecInt32_4.h:951:21: warning: unused variable 't0' [-Wunused-variable]
            __m128i t0 = _mm_set1_epi32(b);
                    ^

gcc seems to be more sensitive and adds additionally

/home/marehr/develope/seqan-src/include/umesimd/plugins/avx512/uint/UMESimdVecUint32_4.h: In member function ‘__mmask8 UME::SIMD::SIMDVec_u<unsigned int, 4u>::m128i_to_mask8(__m128i) const’:
/home/marehr/develope/seqan-src/include/umesimd/plugins/avx512/uint/UMESimdVecUint32_4.h:83:39: warning: overflow in implicit constant conversion [-Woverflow]
                 0x80, 0x80, 0x80, 0x80);
                                       ^

/home/marehr/develope/seqan-src/include/umesimd/plugins/avx512/int/UMESimdVecInt32_4.h: In member function ‘__mmask8 UME::SIMD::SIMDVec_i<int, 4u>::m128i_to_mask8(__m128i) const’:
/home/marehr/develope/seqan-src/include/umesimd/plugins/avx512/int/UMESimdVecInt32_4.h:84:39: warning: overflow in implicit constant conversion [-Woverflow]
                 0x80, 0x80, 0x80, 0x80);
                                       ^

@edanor
Copy link
Owner

edanor commented Nov 17, 2016

Everything should be OK now (with exception of #37). I also fixed the code so that more efficient masking was used for SIMD4.

@edanor
Copy link
Owner

edanor commented Nov 17, 2016

Fixed warnings in Visual Studio. Let me know if you still see anything troubling.

@marehr
Copy link
Contributor Author

marehr commented Nov 21, 2016

I didn't try msvc, yet.

Gcc and clang produce no warnings.

@edanor
Copy link
Owner

edanor commented Nov 28, 2016

I did some testing and didn't notice anything suspicious. I want to close this issue now.

If something weird appears, please just open a new defect report.

@edanor edanor closed this as completed Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants