Special keys can not be inserted on french keyboards

[sebcaux]

Hi, I have found a very embarrasing problem... On my french keyboard it is impossible to insert char like : ~#{[|\^@]} . To insert theses chars, I need to press Alt Gr key that corresponding to Alt + Ctrl

To fix this, I modify the specialKey in TextEditorComponent::keyPressEvent :

    bool specialKey = (modifiers&(Qt::MetaModifier|Qt::ControlModifier))
            && ((modifiers!=(Qt::AltModifier|Qt::ControlModifier)) || text.at(0).isUpper());

I don't know if it is the right way.

[vadi2]

We've got feedback on this as well:

The new editor features in 3.3.1 are delightful! I spend much, much less time tabbing out to Sublime Text since it was introduced.

However, there is one nasty problem I've run into: The new editor seems to hate keyboard layouts with an AltGr key, rejecting any inputs made with it. I'm on a Finnish keyboard; backslashes, brackets, tildes, vertical pipes are all entered with AltGr key combinations - probably obvious how Lua could be tough without these! They worked perfectly fine in previous versions, and continue to in external programs. Inputting these characters still works in every other area of Mudlet, including when editing the trigger lines themselves - it is only in the new editor where these commands fail.

Edit: Alt codes (LAlt+KP60 for < for example) do not worth either. AltGr and Alt key combinations both fail only within the editor.

[gamecreature]

Sorry for the late reaction (currently very busy doing nothing 😉)
I will embed the solution supplied above. I'm not 100% certain this is the correct way to do it.
But it doesn't seem to affect the rest, so I will commit a new version.

    bool specialKey = (modifiers&(Qt::MetaModifier|Qt::ControlModifier))
                  && ((modifiers!=(Qt::AltModifier|Qt::ControlModifier)) || (!text.isEmpty() && text.at(0).isUpper()));

I still have my doubts about the text.at(0).isUpper()..
Aren't there any modifiers keys that don't result in a non-upper key?

Please give me suggestions about this.
I don't know how to test this situation on my Mac..

[PureWhiteWings]

Note: The feedback quoted by vadi2 was mine on a forum.

'Aren't there any modifiers keys that don't result in a non-upper key?'

There are, in fact. I can't speak for many other layouts, but there are numerous inputs that can be made on the Finnish multilingual layout that result in lowercase inputs. None of those should affect my code in Lua (the main language I use within edbee), but it does exist.

I think that goes into 'potential minor annoyance' territory, rather than 'severly limits coding' however. I'm happy to help test solutions, however I realistically can.

[sebcaux]

No problems, it's the hard work of being maintener!

Yes it seems strange the isUpper(), but :

• AltGr = Ctrl + Alt modifier flags
• Ctrl + Alt + 6 = | in event->text()
• Ctrl + Alt + E = € in event->text()
• Ctrl + Alt + A = A in event->text()
  So Ctrl + Alt + letter can still be used as shortcut.

[gamecreature]

@sebcaux Thanks for the feedback!
That's indeed a good solution to keep the shortcuts working