-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
markAll() - slow for many matches #99
Comments
That does't sound very good. I have to look into this. ( Unfortunately I don't have much time these days for Edbee). My first impression is that the markAll and searchAll functions are very inefficient, because it uses a 'findNextRange' call for every item searched. FindNextRange is a method that can called separately. Btw. VSCode probably uses threading for searching in the background. |
…hanges, to prevent updating per item)
@vadi2 Could you check if this improves the situation? |
… endChanges, to prevent updating per item)
We are good on this now, thank you 👍 |
We've got this bit of code that we're using to highlight search matches:
And when we use it on say a 1,000 line document like this, highlighting a single character like
c
takes a really long while:Are we using the API right or is there something that can be done?
We've already disabled highlighting for one or two character searches, but that's more of a workaround than a solution, since VS Code on the same machine handles it okay.
The text was updated successfully, but these errors were encountered: