Fix sui-search styling to allow fluid class to work #372
Labels
Comments
|
Thank you for this, would you be able to open a PR and have a play with the demo to see if you can see any issues? Happy to then double check and we can merge the fix if all ok! |
TroyMurphy
added a commit
to TroyMurphy/ng2-semantic-ui
that referenced
this issue
Aug 23, 2018
Change inline block to block to not restrict container size
TroyMurphy
added a commit
to TroyMurphy/ng2-semantic-ui
that referenced
this issue
Aug 23, 2018
Change inline block to block to not restrict container size and adds fluid search example to documentation
TroyMurphy
added a commit
to TroyMurphy/ng2-semantic-ui
that referenced
this issue
Aug 23, 2018
Change inline block to block to not restrict container size and adds fluid search example to documentation
TroyMurphy
added a commit
to TroyMurphy/ng2-semantic-ui
that referenced
this issue
Aug 23, 2018
Change inline block to block to fix fluid and alignment classes
TroyMurphy
added a commit
to TroyMurphy/ng2-semantic-ui
that referenced
this issue
Aug 23, 2018
Change inline block to block to not restrict container size and adds fluid search example to documentation
TroyMurphy
added a commit
to TroyMurphy/ng2-semantic-ui
that referenced
this issue
Aug 23, 2018
Change inline block to block to repair fluid and align classes undo demo changes
TroyMurphy
added a commit
to TroyMurphy/ng2-semantic-ui
that referenced
this issue
Aug 23, 2018
Changes inline block to block so fluid and alignment work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seems super simple, but I'm not confident enough to know if changing the display affects other things.
Bug description:
sui-search fluid class does not work as bounding container is not expanding as it does in default semantic ui.
Link to minimally-working plunker that reproduces the issue:
http://plnkr.co/edit/X6517cax71hip8z164Lc?p=preview
Version of Angular, ng2-semantic-ui, and Semantic UI:
Angular: 5.0.2
ng2-semantic-ui: 0.9.6
Semantic UI: 2.2.9
Suspected Fix:
https://github.com/edcarroll/ng2-semantic-ui/blob/master/src/modules/search/components/search.ts#LC45
change
inline-blocktoblockThe text was updated successfully, but these errors were encountered: