Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Send NavRoute data on journal schema. #109

Closed
Athanasius opened this issue Nov 4, 2020 · 1 comment
Closed

[Enhancement] Send NavRoute data on journal schema. #109

Athanasius opened this issue Nov 4, 2020 · 1 comment

Comments

@Athanasius
Copy link
Contributor

Athanasius commented Nov 4, 2020

The NavRoute.json file, written when a journal NavRoute event occurs, contains:

  1. System Name
  2. System co-ordinates
  3. SystemAddress (id64)
  4. Main star's class

for each step in the plotted route. It would be simple to take the route array out of the file and insert it into the journal event before sending that over EDDN. Then any listeners could choose to utilise it to potentially gain co-ordinates and systemaddress for extra systems.

As the provided data in the route array is what is currently required as the bare minimum in a journal schema message this shouldn't actually require any changes to the schema other than adding the event type to the allowed list. This issue mostly for reference and any further discussion. It would require a small update to the documentation to explicitly state that the route array needs adding from the file.

@Tkael
Copy link
Member

Tkael commented Sep 24, 2021

Superseded / replaced by #133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants