Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Released Jars don't have the correct filename #112

Closed
eddarmitage opened this issue Apr 11, 2020 · 3 comments
Closed

Released Jars don't have the correct filename #112

eddarmitage opened this issue Apr 11, 2020 · 3 comments
Labels
build & ci Issues with the build and release system released
Milestone
Released

Comments

@eddarmitage
Copy link
Owner

I suspect this is because they are built before the tag is applied - perhaps the ./gradlew assemble step needs to happen as part of the publish semantic-release phase. Running on a local machine, after the release has been made, produces correctly named jars.
@eddarmitage eddarmitage added the build & ci Issues with the build and release system label Apr 11, 2020
@eddarmitage eddarmitage added this to the Released milestone Apr 11, 2020
eddarmitage added a commit that referenced this issue Apr 12, 2020
@eddarmitage
ci(release): build jars after tag creation
942da8e 
Previously the jars were built as part of semantic-version's `prepare` phase, which empirically seems to run before tag creation, contrary to the documentation. This meant that when the jars were built, they were not versioned correctly, as they get their version from the tag (which hasn't been created yet).

Closes #112
@eddarmitage
Copy link
Owner Author

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eddarmitage
Copy link
Owner Author

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

1 similar comment
@eddarmitage
Copy link
Owner Author

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build & ci Issues with the build and release system released
Projects
None yet
Milestone
Released
Development

No branches or pull requests
1 participant
@eddarmitage