Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of (all of) boost/polygon (to also include voronoi.hpp) #63

Closed
Jean-Romain opened this issue Sep 24, 2019 · 4 comments · Fixed by #65
Closed

Addition of (all of) boost/polygon (to also include voronoi.hpp) #63

Jean-Romain opened this issue Sep 24, 2019 · 4 comments · Fixed by #65

Comments

@Jean-Romain
Copy link

@Jean-Romain Jean-Romain commented Sep 24, 2019

I'm currently using boost/polygon/voronoi.hpp to make a fast Delaunay triangulation of large point cloud. Everything was good and I was very happy until I tested the package on CRAN. It does not compile because fatal error: boost/polygon/voronoi.hpp: No such file or directory

I was perplex until I found that on my machine (linux) all the boost header are installed but some are missing in BH. This is why it compiles on my machine but not on CRAN.

I understand that some boost stuff are not in BH but it seems to me that the voronoi stuff is header only. Actually only 3 voronoi_*.hpp headers are missing but most of them are actually present in BH.

So I'm wondering why they are missing? if they can be added in BH? and if it is a viable option to include these files in my own package as a workaround.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

@eddelbuettel eddelbuettel commented Sep 25, 2019

BH adds by Boost library, so your issue really may be whether polygon can be added. (Boost headers tends to inter-depend quite a bit so it is never "just three files".)

That said, Boost polygen appears to be a standard header-only library. We appear to have some files from it already (that happens prevcisely via the aforementioned interdepencies resolved by the bcp tool also used to build BH). So by adding all of polygon you should be set.

I will retitle the Subject: and put it on TODO list.

@eddelbuettel eddelbuettel changed the title Addition of boost/polygon/voronoi.hpp Addition of (all of) boost/polygon (to also include voronoi.hpp) Sep 25, 2019
@Jean-Romain

This comment has been minimized.

Copy link
Author

@Jean-Romain Jean-Romain commented Sep 25, 2019

Thank you Dirk. I now understand why polygon is only partially included in BH. polygon is not actually included in BH at all it is only a side effect of interdependencies in other included parts of boost.

As a workaround I temporarily included polygon in my own package. At least it compiles on CRAN and on rhub. I'm wainting for an update of BH. Anyway I won't release before 2020.

Best.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

@eddelbuettel eddelbuettel commented Sep 25, 2019

Yes, locally adding polygon (preferably from the same Boost release as BH) is the best next step in the very short term. I will try to add polygon to BH at the next update, but I make those fairly infrequently. So if you're not in a rush either we're all good for now. But this should get addressed in due course.

Jean-Romain added a commit to Jean-Romain/lidR that referenced this issue Sep 25, 2019
@eddelbuettel

This comment has been minimized.

Copy link
Owner

@eddelbuettel eddelbuettel commented Dec 15, 2019

Preparing BH 1.72.0 now based on last week's Boost 1.72 release -- with polygon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.