Add static to inline functions #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to avoid a link error where the inline functions appear missing at link time. From c99 standard inline function should either be declared static or have an extern instance in a c file for linking. This fix is necessary to build with gcc 7; for some reason it was not trigerred before. Signed-off-by: Julien Viard de Galbert <julien@vdg.name> [Retrieved from: https://git.buildroot.net/buildroot/tree/package/dieharder/0004-Add-static-to-inline-functions.patch] Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
marcusmueller
approved these changes
Oct 13, 2020
These changes are appropriate and I recommend merging them. static makes the insert symbol only visible inside the the compilation unit (i.e., dab_filltree.o) itself, otherwise I'm running into linking errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is needed to avoid a link error where the inline functions appear
missing at link time.
From c99 standard inline function should either be declared static or
have an extern instance in a c file for linking.
This fix is necessary to build with gcc 7; for some reason it was not
trigerred before.
Signed-off-by: Julien Viard de Galbert julien@vdg.name
[Retrieved from:
https://git.buildroot.net/buildroot/tree/package/dieharder/0004-Add-static-to-inline-functions.patch]
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com