Fix off_t and size_t printf warnings on 32/64 bit systems. #26
Conversation
Dieharder already uses _FILE_OFFSET_BITS=64, so off_t type is always 64bit signed integer. However, on 32bit platforms is is presented as long long, while on 64bit it is just long (as long type is 64bit there). As there is no specific format prefix for off_t, IMO, the safest is to use integer promotion - use larges type prefix %lld and cast value to (long long) in printf. Also switch printf to signed integer, as off_t is always signed. For size_t we have the same issue, but here we have already print prefix %zu that will handle size_ on all patforms.
|
I think this goes in the right direction but it is 2024 and I am not a fan of propagating Can you consider the comment I made in #25 even if it may mean switching format strings to |
|
Do you mean to use |
|
(I tried to avoid change in exported structs. But if you want to change it, then to replace off_t with explicit 64bit type is definitely better. But despite it is binary equvalent, it guess it will be treated as API change by some tools...) |
|
Hm. That is tricky either way. |
yes :) I think the whole code is full of old C. On the other side, off_t is really not a good choice here. Anyway, let me know what variant you prefer, I can change it once I get back to it. |
Dieharder already uses _FILE_OFFSET_BITS=64, so off_t type is always 64bit signed integer.
However, on 32bit platforms is is presented as long long, while on 64bit it is just long (as long type is 64bit there).
As there is no specific format prefix for off_t, IMO, the safest is to use integer promotion - use larges type prefix %lld and cast value to (long long) in printf.
Also switch printf to signed integer, as off_t is always signed.
For size_t we have the same issue, but here we have already print prefix %zu that will handle size_ on all patforms.
This should replace some part of #25 except sscanf issues.