Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pruneRepo fails with for package type mac.binary.big-sur-arm64 #134

Closed
botanize opened this issue Sep 21, 2022 · 1 comment
Closed

pruneRepo fails with for package type mac.binary.big-sur-arm64 #134

botanize opened this issue Sep 21, 2022 · 1 comment

Comments

@botanize
Copy link
Contributor

While insertPackage became mac.binary.big-sur-arm64 aware, it looks like pruneRepo and archivePackages did not.

It's currently failing for me when attempting to match the type parameter because mac.binary.big-sur-arm64 isn't included in the valid options, here:

pruneRepo <- function(repopath = getOption("dratRepo", "~/git/drat"),

proposed solution

Change

type = c("source", "binary", "mac.binary", "mac.binary.el-capitan",
                               "mac.binary.mavericks", "win.binary", "both")

to

type = c("source", "binary", "mac.binary", "mac.binary.big-sur-arm64",
                               "mac.binary.el-capitan", "mac.binary.mavericks", "win.binary", "both")

For the affected lines in pruneRepo.R and archivePackages.R.

I'm happy to submit a PR and update testArmBinary.R to test archive and prune functionality.

@eddelbuettel
Copy link
Owner

Good catch. It is possible that we overlooked this when adjusting the inserter.

As you have the ability to test this locally would you mind setting up a PR you could test? I cannot easily 'mock' being on such a macOS variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants