add mac.binary.big-sur-arm64 to type param (closes #134) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I was insufficiently clear in #134 and we are on the same page: because it is hard to automate the test at CI I was basically trying (and failing) to ask you to 'test locally' and to then assert with a straight face that it works. Which would be good enough for now and likely better than what we have. Also, can you add a quick entry to ChangeLog noting the file changed with a line and the usual header of date, your name and email? Thanks so much! |
eddelbuettel
changed the title
|
Thanks for the update! I'll just wait for the pro-forma CI run (which failed earlier as launchpad was down/upgrading, which is rare) and then I'll merge. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #134
This PR simply adds
action = 'prune'to theinsertPackagecall intests/testArmBinary.R. That's where I was running into problems.Not sure how much to invest in the tests because as far as I can tell, the tests only run on R 4.1.x and the CI is configured to use R 4.0.x. If I got that wrong let me know. However, these changes fixed the problems I was having inserting with action = prune.