fix for support dots, solves #39

[jangorecki]

tested on data.table_1.9.6.zip file.
I could add tests for that fix but I would need to keep drat_1.0.0.zip locally in inst.

[eddelbuettel]

Confirmed.

I am not sure what you are trying to say with

I could add tests for that fix but I would need to keep drat_1.0.0.zip locally in inst.

[jangorecki]

wait, underscores seems to be not valid in pkg names, so it don't need to handle them, I will update for just dots
I mean I could add tests for that PR into tests/simpleTests.R but I would need to store some zip locally in inst I believe.

[eddelbuettel]

Worked here:

R> gsub("^([a-zA-Z0-9._]*)_.*", "\\1", basename("data.table_1.9.6"))
[1] "data.table"
R> gsub("^([a-zA-Z0-9._]*)_.*", "\\1", basename("data._table_1.9.6"))
[1] "data._table"
R> gsub("^([a-zA-Z0-9._]*)_.*", "\\1", basename("data_table_1.9.6"))
[1] "data_table"
R> 

I will not merge a patch for just dots. So please revert to what you had perform and what I had suggested in #39.

[jangorecki]

@eddelbuettel if underscore in the package name is not considered to be valid then why you would like to handle them?

[eddelbuettel]

Oh, I would accept that as a counter argument :) Does Writing R Extension prohibit it? Indeed I do not seem to have an installed package with an underscore.

We could still allow this for local / internal packages, or do R CMD build even prohibit it?

[eddelbuettel]

Ok, found it:

The mandatory 'Package' field gives the name of the package. This
should contain only (ASCII) letters, numbers and dot, have at least two
characters and start with a letter and not end in a dot. If it needs
explaining, this should be done in the 'Description' field (and not the
'Title' field).

Convinced now :)