Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uppruneRepo and archivePackages updated to work with binary packages. #79
Conversation
|
Thanks -- though twelve modified functions is a lot for an unannounced PR. We prefer prior discussion. But I'll take a look. |
…constructed using contrib.url() now
|
Looks good! |
|
@jangorecki Do you want to take another look? |
afbfe93
into
eddelbuettel:master
|
Looks good, I would only advice to put formatting changes, like |
|
Hi @eddelbuettel and @jangorecki , thanks for your very helpful comments (especially on how to do a PR). Looking forward to use the updated version here at work. |
|
Yes, both the white-space changes and the roxygen2-induced changes made this noisier but we coped :) Thank you both. Will ship a new version to CRAN. |
|
Thanks again -- new version sailed to CRAN without an issue (as we're all 'OK' on each platform and have no reverse depends). So all good now :) Congrats to Christoph for a fine first PR (just hold back the whitespace changes next time ;-) and thanks again also to Jan for looking over my shoulder. Updated code for version 0.1.5 in master now too. |
Hi Dirk,
we are implementing drat in our company to supply a CRAN-like repo to our coworkers. As we are on Windows, we usually provide *.zip packages.
We modified the functions archivePackages and pruneRepo in order to work with binary packages.
Best, Christoph