No longer set a default compilation standard #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsilvest
approved these changes
Mar 22, 2023
|
Yes, right, will take a careful look at the valgrind info - might be something that could spell trouble. |
|
I just rebased that (older) branch (which I once thought would help with valgrind but doesn't). Rebase just in case. Maybe we should merge that one anyway "as it doesn't hurt". |
|
Sure, I'm OK with merging that change. Might take me a bit of time to find what is irritating valgrind. |
|
Made it a proper PR now so fire away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like in nanotime PR #114, we can remove the
CXX_STDsetting as the right thing happens by default.We should make some time for the other branch / still draft PR with valgrind nag. I'll try to poke one of these days. I just re-confirmed it is still 'live'.