Fix two bugs and add corresponding tests #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The first one prevented correctly moving a DLL in case the function in the source code had been given a user specified name. - readCFunc did not return a CFunc object as restoring the pointer after reading downgraded the object to a regular function. Now readCFunc obtains the code before restoring the pointer, coerces the function to a CFunc object afterwards and restores the content of the code slot.
jranke
added a commit
to jranke/mkin
that referenced
this pull request
Nov 27, 2020
Depends on inline >= 0.16.2 (including the bug fixes from eddelbuettel/inline#18), which provides 'moveDLL' to store the DLL for a compiled function in a safe place in case the argument 'dll_dir' is specified in the call to 'mkinmod'. Huge thanks to Dirk @eddelbuettel for his review and support for the work on the inline package.
|
winbuilder does not like the DLL move. Can you fix, or shall we ... skip the test on Windows? |
|
See #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the source code had been given a user specified name.
after reading downgraded the object to a regular function. Now
readCFunc obtains the code before restoring the pointer,
coerces the function to a CFunc object afterwards and restores
the content of the code slot.