Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some code that turned out to be unnecessary (unloading and reloading the DLL in 'moveDLL'), and which does not work with current R-devel, presumably due svn commit r80285 addressing PR#16446. The commit message contains the phrase "Zero external pointers of native symbols of unloaded DLLs", and I do observe that unloading the DLL in moveDLL removes the pointer with current R-devel. So with this commit we do not unload the old DLL any more in 'moveDLL'. The only unloading that takes place now is in case a DLL is already loaded from the target location of 'moveDLL'.
I tested this locally with R 4.0.5 and current R-devel on Linux, as well as on r-hub (Windows, Ubuntu gcc and Fedora clang), all went well. I also uploaded to winbuilder - Dirk, you have probably received the e-mail.
I also tested 'mkin' which makes use of 'moveDLL', everything appears to be fine. I am not aware that any other packages use 'moveDLL' but we may still want to do reverse dependency checks before uploading. I have never needed to do this, so I do not have a workflow for it.