Small fix to allow for the main architecture to be installed as a sub architecture #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kewl, thanks for suggesting that. As I am not on a mac, that is where it gets auto-installed? The binaries by @jeroen seem to differ: So do CRAN's: edd@rob:/tmp/r/littler$ wget -q https://cran.r-project.org/bin/macosx/big-sur-arm64/contrib/4.3/littler_0.3.19.tgz
edd@rob:/tmp/r/littler$ tar tfz littler_0.3.19.tgz | grep bin
littler/bin/
littler/bin/r
edd@rob:/tmp/r/littler$ rm littler_0.3.19.tgz
edd@rob:/tmp/r/littler$ wget -q https://cran.r-project.org/bin/macosx/big-sur-x86_64/contrib/4.3/littler_0.3.19.tgz
edd@rob:/tmp/r/littler$ tar tfz littler_0.3.19.tgz | grep bin
littler/bin/
littler/bin/r
edd@rob:/tmp/r/littler$ So why does it reflect the arch for you? Should we at least do something that accounts for either in the message? |
| @@ -5,7 +5,7 @@ | |||
| packageStartupMessage("and see 'vignette(\"littler-faq\") for some basic questions.") | |||
| if (Sys.info()[["sysname"]] %in% c("Linux", "Darwin")) { # nocov start | |||
| if (unname(Sys.which("r")) == "") { | |||
| loc <- normalizePath(file.path("bin", .Platform$r_arch, "r", package="littler")) | |||
| loc <- normalizePath(system.file("bin", .Platform$r_arch, "r", package="littler")) | |||
There was a problem hiding this comment.
Thank you. I often catch myself using file.path() when I think of concatenating, we of course meant system.file() here as before.
eddelbuettel
approved these changes
Mar 10, 2024
eddelbuettel
added a commit
that referenced
this pull request
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.