New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more robust error handling for install2.r #50

Merged
merged 1 commit into from May 1, 2017

Conversation

Projects
None yet
2 participants
@cboettig
Contributor

cboettig commented May 1, 2017

install2.r has long had the option -e or --error to make the script throw an error instead of the default behavior of a waring if install.packages fails to successfully install the package. Unfortunately, since R 3.4.0, utils has started throwing a warning if the target repo does not have a PACKAGES.rds in src/contrib. Many drat repositories just build src/contrib/PACKAGES and src/contrib/PACKAGES.gz, so this means that the install2.r script now fails to install from drat repos (which is very sad, because drat repos are great).

This patch provides a more robust approach to error when a package fails to install, but not simply error on any possible warning (as it does currently). This involves no change to the user interface of install2.r

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel May 1, 2017

Owner

Making this more robust is good. Medium-term we're good too because drat just calls out to the base tools to create indices which, if you use R 3.4.0 or later, will write PACKAGES.rds for you.

But that doesn't fix old repos, not does it help for older install. Will review the PR when I have moment or two and also think I should get a littler update out ...

Dirk

Owner

eddelbuettel commented May 1, 2017

Making this more robust is good. Medium-term we're good too because drat just calls out to the base tools to create indices which, if you use R 3.4.0 or later, will write PACKAGES.rds for you.

But that doesn't fix old repos, not does it help for older install. Will review the PR when I have moment or two and also think I should get a littler update out ...

Dirk

@eddelbuettel eddelbuettel merged commit f0a958e into eddelbuettel:master May 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment