more robust error handling for install2.r #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Making this more robust is good. Medium-term we're good too because drat just calls out to the base tools to create indices which, if you use R 3.4.0 or later, will write PACKAGES.rds for you. But that doesn't fix old repos, not does it help for older install. Will review the PR when I have moment or two and also think I should get a littler update out ... Dirk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install2.r has long had the option
-eor--errorto make the script throw an error instead of the default behavior of a waring ifinstall.packagesfails to successfully install the package. Unfortunately, since R 3.4.0,utilshas started throwing a warning if the target repo does not have aPACKAGES.rdsinsrc/contrib. Many drat repositories just buildsrc/contrib/PACKAGESandsrc/contrib/PACKAGES.gz, so this means that the install2.r script now fails to install from drat repos (which is very sad, because drat repos are great).This patch provides a more robust approach to error when a package fails to install, but not simply error on any possible warning (as it does currently). This involves no change to the user interface of install2.r