Improve error detection on failed download #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a package can't be downloaded, a warning appears:
Warning in download.packages(pkgs, destdir = tmpd, available = available, :
download of package ‘vcd’ failed
The package is not installed and install2.r returns successfully (even though
we use --error).
This commit captures that warning so the error can be raised
eddelbuettel
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
That looks good (and useful) to me! I'll poke @cboettig too who is behind this option and feature but I see no reason not to merge (though I still always prefer an issue ticket prior to a PR but as this one is small I can see that would maybe be too much formalism...)
|
apologies for the slow reply but this looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a package can't be downloaded, a warning appears:
The package is not installed, but install2.r returns successfully even though
we use
--error.This commit captures that warning so the error can be captured and returned.
One way to simulate this error is by making
/tmp/downloaded_packagesnot writeable.