Merge pull request #13 from eddelbuettel/bugfix/issue12

fix for formating precision loss (closes #12)

ChangeLog

@@ -1,3 +1,8 @@
+2017-01-30  Dirk Eddelbuettel  <edd@debian.org>
+
+	* R/nanotime.R (format.nanotime): Saver transformation to double
+	(index2char.nanotime): Idem
+
 2017-01-29  Dirk Eddelbuettel  <edd@debian.org>
 
 	* R/nanotime.R: Additional documentation section on default output

R/nanotime.R

@@ -146,16 +146,18 @@ format.nanotime <- function(x,
                             ...) {
     fmt <- getOption("nanotimeFormat", default="%Y-%m-%dT%H:%M:%E9S%Ez")
     tz <- getOption("nanotimeTz", default="UTC")
-    secs  <- trunc(as.double(x/1e9))
-    nanos <- as.double(x - secs*1e9)
-    RcppCCTZ::formatDouble(secs, nanos, fmt=fmt, tgttzstr=tz)
+    bigint <- as.integer64(x)
+    secs  <- as.integer64(bigint / as.integer64(1000000000))
+    nanos <- bigint - secs * as.integer64(1000000000)
+    RcppCCTZ::formatDouble(as.double(secs), as.double(nanos), fmt=fmt, tgttzstr=tz)
 }
 
 ##' @rdname nanotime
 index2char.nanotime <- function(x, frequency = NULL, ...) {
-    secs  <- trunc(as.double(x/1e9))
-    nanos <- as.double(x - secs*1e9)
-    RcppCCTZ::formatDouble(secs, nanos,
+    bigint <- as.integer64(x)
+    secs  <- as.integer64(bigint / as.integer64(1000000000))
+    nanos <- bigint - secs * as.integer64(1000000000)
+    RcppCCTZ::formatDouble(as.double(secs), as.double(nanos),
                            fmt=getOption("nanotimeFormat", default="%Y-%m-%dT%H:%M:%E*S%Ez"),
                            tgttzstr=getOption("nanotimeTz", default="UTC"))
 }

inst/NEWS.Rd

@@ -11,6 +11,8 @@
     and a new new converter \code{as.integer64} was added.
     \item Several 'Ops' method are now explicitly defined allowing
     casting of results (rather than falling back on bit64 behaviour)
+    \item The format routine is now more careful about not loosing
+    precision (\ghit{12})
   }
 }