feat: Support default zeros in 'nanoduration()' #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds default zeros to `nanoduration()` in a reverse-compatible way * Can now do `nanoduration(seconds = 20)` instead of having to do `nanoduration(hours = 0, minutes = 0, seconds = 20, nanoseconds = 0)`
eddelbuettel
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
That's another rather nice catch and I am now wondering why on earth we did not think about that.
Merging merging I want to give @lsilvest a chance to pipe though -- but LGTM!
|
@lsilvest -- if you have a moment a quick glancing review would be appreciated just in case. I'll merge directly otherwise in a day or two. |
lsilvest
approved these changes
Oct 14, 2022
Yes, looks like we don't use our own code enough :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nanoduration()in a reverse-compatible waynanoduration(seconds = 20)instead of having to donanoduration(hours = 0, minutes = 0, seconds = 20, nanoseconds = 0)