-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: '+' / '-' methods for {nanotime} objects and 'difftime()' objects #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you -- that too looks good. I will wait for @lsilvest to nod as well before merging.
If we do have Also I would ideally prefer the unit tests to be distinct for each function added. Admittedly they are not very complicated, but one never knows what can break down the line and hence if one will need these separate unit tests. |
* nanoival() + difftime() * difftime() + nanoival() * nanoival() - difftime() * nanoduration() + nanoival() (arguably missing S4 method) * nanoival() - nanoduration() (arguably missing S4 method)
@lsilvest Each new method now has its own individual test and I've added the following new S4
|
* Adds a 'setOldClass("difftime")' which we probably "should" do * Eliminates some warnings when running 'devtools::load_all()' but otherwise no detectable change (i.e. in 'R CMD check')
Thank you @trevorld for the added (and updated) PR and to @lsilvest for catching that If this completes the set of changes @trevorld is planning to bring I can look into a quick release in a few days. (Got a few emails from CRAN about clang-15 changes I should chew on first so likely early next week for this if we are good with that.) |
This completes the set of changes I was planning. |
Got around to that late yesterday, and by now Uwe processed and the new version is on CRAN. Many thanks again to @trevorld for all the careful patches in it. |
Adds the following S4 methods:
closes #107, closes #108