-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors for ops not meaningful for 'nanotime' + handle NA, NaN, Inf, -Inf #27
Conversation
I'll merge, but I'll go back to just 'squash merge' because our trees have aligned to poorly in the past. Ok? |
Yes, absolutely. I'll read about why I was forced to do yet another merge after my changes. Do you have any other suggestions ? Should I throw away my fork and start a new one?
|
I manage to create mini-versions of the problem just by myself between laptop and server (or a third machine). I think the key really is simply to remain current, and to branch cleanly from master. If that branch then gets merged all is well. Which is pretty doable in a calmer repo like this where it is only you and me, and rarely at the same time. But I do have colleagues who manage to create pretty impressive spaghetti patterns at work merging between branches and what not... Doesn't matter greatly but also not that hard to get right. |
Otherwise, ready for a new release? |
Josh pipes in via private slack:
|
Josh pipes in via GitHub comments: You need to configure and sync your fork to avoid these types of merge commits. I usually update via Here's a decent article that explains forks and upstreams, and has a cool bash function that tells you how many commits ahead/behind your fork is. |
Thanks for the tips! |
Yes, I think this version is good enough for a release. I didn't find anything else while playing around with |
Thanks @joshuaulrich those are good. Added to my (old) Something that has always worked for me from this is
followed by |
No description provided.