Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors for ops not meaningful for 'nanotime' + handle NA, NaN, Inf, -Inf #27

Merged
merged 3 commits into from
Jun 14, 2017

Conversation

lsilvest
Copy link
Collaborator

No description provided.

@eddelbuettel
Copy link
Owner

I'll merge, but I'll go back to just 'squash merge' because our trees have aligned to poorly in the past.

Ok?

@lsilvest
Copy link
Collaborator Author

lsilvest commented Jun 14, 2017 via email

@eddelbuettel
Copy link
Owner

I manage to create mini-versions of the problem just by myself between laptop and server (or a third machine).

I think the key really is simply to remain current, and to branch cleanly from master. If that branch then gets merged all is well. Which is pretty doable in a calmer repo like this where it is only you and me, and rarely at the same time. But I do have colleagues who manage to create pretty impressive spaghetti patterns at work merging between branches and what not...

Doesn't matter greatly but also not that hard to get right.

@eddelbuettel eddelbuettel merged commit 9c063d8 into eddelbuettel:master Jun 14, 2017
@eddelbuettel
Copy link
Owner

Otherwise, ready for a new release?

@eddelbuettel
Copy link
Owner

Josh pipes in via private slack:

The answer to Leonardo's question about Git is that he's likely not sync'ing with your repo before he starts committing again, so he's missing the merge commit from his prior PR.

@joshuaulrich
Copy link
Sponsor

Josh pipes in via GitHub comments:

You need to configure and sync your fork to avoid these types of merge commits. I usually update via git fetch --all, then git merge --ff-only upstream/master. The merge command will fail if my local master is behind upstream/master. In that case, I'll run git rebase -i master upstream/master.

Here's a decent article that explains forks and upstreams, and has a cool bash function that tells you how many commits ahead/behind your fork is.

@lsilvest
Copy link
Collaborator Author

Thanks for the tips!

@lsilvest
Copy link
Collaborator Author

Yes, I think this version is good enough for a release. I didn't find anything else while playing around with nanotime.

@eddelbuettel
Copy link
Owner

Thanks @joshuaulrich those are good. Added to my (old) ~/git/README.txt.

Something that has always worked for me from this is

followed by git pull --all; git merge parentrepo. By having --track master here I don't need it in the subsequent merge command as you do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants