tz= to tzstr= to avoid partial argument match #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Dirk,
In data.table we now run tests with R's `warnPartialMatchArgs` turned on, . This revealed this one line in nanotime since we have tests of nanotime with data.table.
```
> options(warnPartialMatchArgs=TRUE)
> nanotime("2016-09-28T15:30:00.000000070Z")
[1] "2016-09-28T15:30:00.000000070+00:00"
Warning message:
In RcppCCTZ::parseDouble(x, fmt = format, tz = tz) :
partial argument match of 'tz' to 'tzstr'
```
It came up because a user wished to turn on this option for their own code in production to be strict themselves. But then internal code of data.table was caught by it too. So now we turn it on in tests, and stopped relying on partial argument match ourselves in internal data.table code. It's a nice improvement and caught a few things. I didn't know about this option before actually.
Hope you enjoyed Toulouse.
Best, Matt
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 93 93
=====================================
Hits 93 93
Continue to review full report at Codecov.
|
|
Saw the tweet about the NEWS item, and sorry for this -- and thanks for the PR. Will fold it in. Greetings from Toulouse airport. Saw Jens here too, we missed you once more. |
eddelbuettel
approved these changes
Jul 13, 2019
|
Thanks again. Now merged, given that I am home. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dirk,
In data.table we now run tests with R's
warnPartialMatchArgsturned on. This revealed this one line in nanotime since we have tests of nanotime with data.table.It came up because a user wished to turn on this option for their own code in production to be strict themselves. But then internal code of data.table was caught by it too. So now we turn it on in tests, and stopped relying on partial argument match ourselves in internal data.table code. It's a nice improvement and caught a few things. I didn't know about this option before actually.
Hope you enjoyed Toulouse.
Best, Matt