Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upsynchronized C code with R 3.5.1 source, updated ChangeLog and NEWS #3
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
===========================================
+ Coverage 54.67% 82.31% +27.64%
===========================================
Files 6 6
Lines 1017 622 -395
===========================================
- Hits 556 512 -44
+ Misses 461 110 -351
Continue to review full report at Codecov.
|
|
This looks good to me. I looked at the diff ignoring whitespace changes. |
|
Thanks. It's kinda harder for you as you'd really need a three-way diff between current R, current RApiDatetime, previous RApiDatetime. |
@joshuaulrich If you could casually review -- this had been a 'todo' item for some time. Looks like there weren't too many changes. I compared with R 3.5.1 and carried a few little things over. Yay or nay?
And yes, consider this penance for shipping PRs with ChangeLog or NEWS entries ;-)