New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronized C code with R 3.5.1 source, updated ChangeLog and NEWS #3

merged 3 commits into from Oct 20, 2018


None yet
3 participants

eddelbuettel commented Oct 20, 2018

@joshuaulrich If you could casually review -- this had been a 'todo' item for some time. Looks like there weren't too many changes. I compared with R 3.5.1 and carried a few little things over. Yay or nay?

And yes, consider this penance for shipping PRs with ChangeLog or NEWS entries ;-)


This comment has been minimized.

codecov-io commented Oct 20, 2018

Codecov Report

Merging #3 into master will increase coverage by 27.64%.
The diff coverage is 70.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #3       +/-   ##
+ Coverage   54.67%   82.31%   +27.64%     
  Files           6        6               
  Lines        1017      622      -395     
- Hits          556      512       -44     
+ Misses        461      110      -351
Impacted Files Coverage Δ
src/Rstrptime.h 100% <ø> (+75.47%) ⬆️
src/attrib.c 76.47% <50%> (-3.53%) ⬇️
src/datetime.c 80.26% <71.42%> (+13.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad44621...52171f1. Read the comment docs.


This comment has been minimized.


joshuaulrich commented Oct 20, 2018

This looks good to me. I looked at the diff ignoring whitespace changes.


This comment has been minimized.


eddelbuettel commented Oct 20, 2018

Thanks. It's kinda harder for you as you'd really need a three-way diff between current R, current RApiDatetime, previous RApiDatetime.

eddelbuettel added some commits Oct 20, 2018

@eddelbuettel eddelbuettel merged commit 3ba3362 into master Oct 20, 2018

4 checks passed

codecov/patch 70.45% of diff hit (target 54.67%)
codecov/project 82.31% (+27.64%) compared to ad44621
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@eddelbuettel eddelbuettel deleted the feature/sync_with_upstream branch Oct 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment