built on windows #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You rock. That was unbelievably fast as I only blogged about the wouldn't it be nice this morning! Now, the patch is [mostly] against annoylib -- so do you want to fork Annoy as well to get a contributor credit? If you'd rather not I'd be happy too as @erikbern has let a few of my PRs in. But this is very much your work, so you ought to get a credit too ... |
eddelbuettel
added a commit
that referenced
this pull request
Nov 16, 2014
|
OK. I will do that myself. Actually I have been porting some C++ code to Windows for last week and |
|
Sounds good. Tell @erikbern I said Hi :) |
|
Oh, and maybe just copy over the two lines I added in RcppAnnoy to give provenance and license. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mmapfor Windows implementation is from https://code.google.com/p/mman-win32/.And now RcppAnnoy passed the
R CMD checkon windows (http://win-builder.r-project.org/XXJ1PZFHgu7l/00check.log).I have used this
mmapimplementation when porting software to Windows. It works well although the efficiency may not be that good.