Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbuilt on windows #2
Conversation
|
You rock. That was unbelievably fast as I only blogged about the wouldn't it be nice this morning! Now, the patch is [mostly] against annoylib -- so do you want to fork Annoy as well to get a contributor credit? If you'd rather not I'd be happy too as @erikbern has let a few of my PRs in. But this is very much your work, so you ought to get a credit too ... |
9742f69
into
eddelbuettel:master
|
OK. I will do that myself. Actually I have been porting some C++ code to Windows for last week and |
|
Sounds good. Tell @erikbern I said Hi :) |
|
Oh, and maybe just copy over the two lines I added in RcppAnnoy to give provenance and license. |
The
mmapfor Windows implementation is from https://code.google.com/p/mman-win32/.And now RcppAnnoy passed the
R CMD checkon windows (http://win-builder.r-project.org/XXJ1PZFHgu7l/00check.log).I have used this
mmapimplementation when porting software to Windows. It works well although the efficiency may not be that good.