New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::get_time and strptime for the truly unfortunate. (Closes #9) #11

Merged
merged 12 commits into from Jan 7, 2017

Conversation

Projects
None yet
2 participants
@dcdillon
Contributor

dcdillon commented Dec 31, 2016

This adds a backport of std::get_time (in the std_backports namespace) and shores up the strptime() implementation based on std::get_time.

Windows here we come!

@dcdillon dcdillon changed the title from std::get_time and strptime for the truly unfortunate. to std::get_time and strptime for the truly unfortunate. (Closes #9) Dec 31, 2016

Show outdated Hide outdated src/time_zone_format.cc
Show outdated Hide outdated src/time_zone_format.cc
Show outdated Hide outdated src/time_zone_format.cc
Moving things around a bit. Temporary commit to move the changes from…
… my desk to my bedroom because my network isn't quite right.
Show outdated Hide outdated src/time_zone_format.cc
Show outdated Hide outdated src/time_zone_format.cc
@dcdillon

This comment has been minimized.

Show comment
Hide comment
@dcdillon

dcdillon Jan 6, 2017

Contributor

Lol read the commit comment

Contributor

dcdillon commented Jan 6, 2017

Lol read the commit comment

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Jan 6, 2017

Owner

Ouch. Damn ipOverPower messing with you?

Owner

eddelbuettel commented Jan 6, 2017

Ouch. Damn ipOverPower messing with you?

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Jan 6, 2017

Owner

I am not sure I like the last change set. I don;t think I want to change away from %F %T by default. I'd rather condition.

But it looks like you have a build failure to catch anyway?

Owner

eddelbuettel commented Jan 6, 2017

I am not sure I like the last change set. I don;t think I want to change away from %F %T by default. I'd rather condition.

But it looks like you have a build failure to catch anyway?

@dcdillon

This comment has been minimized.

Show comment
Hide comment
@dcdillon

dcdillon Jan 6, 2017

Contributor

Gotcha...no more time tonight. Will have to address in the morning. For now, everything should work correctly on every platform.

Contributor

dcdillon commented Jan 6, 2017

Gotcha...no more time tonight. Will have to address in the morning. For now, everything should work correctly on every platform.

@eddelbuettel eddelbuettel merged commit de8629f into eddelbuettel:master Jan 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment