Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/always int64 #55

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Feature/always int64 #55

merged 2 commits into from
Oct 27, 2020

Conversation

knapply
Copy link
Collaborator

@knapply knapply commented Oct 25, 2020

Addressing #54.

@eddelbuettel, It also expands test coverage and makes some minor tweaks to existing ones as I needed to add tests for this anyways.

It's not remotely a rush - I just wanted to get it here while I'm still thinking about it.

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #55 into master will increase coverage by 8.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   84.15%   92.58%   +8.42%     
==========================================
  Files          18       18              
  Lines        1218     1321     +103     
==========================================
+ Hits         1025     1223     +198     
+ Misses        193       98      -95     
Impacted Files Coverage Δ
inst/include/RcppSimdJson/deserialize/vector.hpp 96.87% <ø> (+0.20%) ⬆️
src/internal-utils.cpp 98.11% <ø> (+3.66%) ⬆️
R/fload.R 100.00% <100.00%> (+3.84%) ⬆️
R/fparse.R 100.00% <100.00%> (+3.57%) ⬆️
inst/include/RcppSimdJson/deserialize.hpp 86.78% <100.00%> (+23.21%) ⬆️
...t/include/RcppSimdJson/deserialize/Type_Doctor.hpp 100.00% <100.00%> (+4.60%) ⬆️
...nst/include/RcppSimdJson/deserialize/dataframe.hpp 97.80% <100.00%> (+27.80%) ⬆️
inst/include/RcppSimdJson/deserialize/matrix.hpp 100.00% <100.00%> (ø)
inst/include/RcppSimdJson/deserialize/simplify.hpp 100.00% <100.00%> (ø)
inst/include/RcppSimdJson/utils.hpp 98.75% <100.00%> (+2.45%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6117bd...95831a0. Read the comment docs.

@eddelbuettel
Copy link
Owner

Looks fab at a first glance. I'll try to come back to it in a day or two.

Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive as usual, can't see anything to nag about :)

@eddelbuettel eddelbuettel merged commit 25089b9 into master Oct 27, 2020
@eddelbuettel eddelbuettel deleted the feature/always_int64 branch October 28, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants