Supporting adding request headers to fload #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 87.11% 96.13% +9.02%
==========================================
Files 4 18 +14
Lines 194 1372 +1178
==========================================
+ Hits 169 1319 +1150
- Misses 25 53 +28
Continue to review full report at Codecov.
|
eddelbuettel
force-pushed
the
feature/request_header
branch
from
8be8ffb
to
e9f1a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor addition but review would be nice just to make sure we agree on style and naming, I don't want to rush it only to come back in a bit and go what were we thinking? ..., The functionality is lovely.
One related thought that came up: Running the request that drove this (for a market data 'quote' request from https://tiingo.com) reveals that resulting order in the returned object may be random. Which sucks for stacking or
rbind-ing data. Shall we add an option to may simply order columns by name? Or is this a 'best left to user' issue?data.tablehas an easysetcolorderthat is already cheap so I could live with that too, but it seems user-unfriendly at a glance...