-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(issue #64) add always_list
parameter (fparse/fload)
#65
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 96.18% 96.21% +0.02%
==========================================
Files 18 18
Lines 1363 1373 +10
==========================================
+ Hits 1311 1321 +10
Misses 52 52
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as usual! I can deal with the codecov nag separately.
I think I would have put the new named argument at the end by some time honoured convention though ...
The codecov should be fixed momentarily. The rationale behind the argument order is that the arguments that are applicable to both |
Makes sense, I didn't pick up on that. |
Thank you very much for the open-mindedness and the quick implementation! |
Resolves #64.