Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
check _WIN32 rather than WIN32 #22
added a commit
this pull request
Feb 12, 2016
oh, ok, it looks like the issue is that the R headers (in 3.2.3 at least) are still using #ifdef WIN32
line 77 here:
are you interested in following this up @eddelbuettel ? brian ripley always hurts my feelings.
Hm, why are tossing around URLs to a 3rd party site on friggin' GitHub when there is wch's well known mirror?
As you are the one troubled by this, could you possibly try something with all of
Anything else we are missing, @kevinushey ?
Otherwise I may just revert and close this as Rtools with 4.9.* is not yet operational and we do releases here for CRAN. Which passed. And still pass.
That said, we may as well plan for a world with a real C++ compiler so your probing is appreciated, @jeroenooms !
I don't think there's anything else that needs to be done on the RInside side. You could probably just add something like:
before including the R headers. That said, I think that
apparently news hadn't made it to my search engine :P
looking here, there's still the #ifdef Win32
so i'm pretty sure the issue would persist in r-devel, etc.
I am not sure what your point is. Do you think we need
#ifndef WIN32 #ifdef _WIN32 #define WIN32 #endif #endif
It is not our job to make R itself ready for g++ 4.9.* on Windoze. We look after a particular package here, and it builds with the tools I have at my disposal namely win-builder. You need to submit easier to understand, and more clearly argued, requests for changes.
Right, I mean that if @jonathon-love wanted to work around the issues with R's headers locally he could use something like
I don't think there's any more changes to be made on the RInside side; R likely will need to change something to accommodate the new toolchain and C++11.