Updated simpleTests.R to use new test variables.
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saved results & tested to make sure test hasn't failed in each situation, return error on fail.
| if(!result$active){ | ||
| stop("Test Failed.") | ||
| } | ||
| ## storing this test result to allow us to use active user's email for testing below. | ||
|
|
There was a problem hiding this comment.
If this first test failed for me yesterday, and if if you only test for email and channel, I suspect it will still fail for me.
Which means that we borked what was working behaviour -- fallback to default device.
|
Aiee. Looks like I overlooked this at first, and we then did similar changes. But if I now look at the remaining change, it really is just one line and some whitespace. So maybe skip this PR? |
|
My last commit cleans this up so the only remaining changes are the |
eddelbuettel
added a commit
that referenced
this pull request
Jan 22, 2015
|
Sorry, missed that -- that would have been cleaner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
simpleTests.Rto use new test variables.activevariable should beTRUE, (except for deleted posts) so this variable tell us that the post was posted successfully.to freeze (pun intended) for some reason. (Had to delete app & re-install to have app working again. - Bug report submitted to the Pushbullet folks.)