Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ISA_TML and BA_GEST #18

Closed
wants to merge 1 commit into from
Closed

Add ISA_TML and BA_GEST #18

wants to merge 1 commit into from

Conversation

randombenj
Copy link

No description provided.

@eddex
Copy link
Owner

eddex commented Jan 13, 2020 •
edited

As I mentioned in #17

Add your changes to tools/parse_module_type.py and let the script generate a new version of data/modules_i.json. 🐔

You can find instructions here:

hslu-simple-mep-results/tools/parse_module_type.py

Line 8 in 08cd529

To get started download the html file from

@eddex eddex mentioned this pull request Jan 13, 2020
Closed
@Lextum Lextum added the invalid This doesn't seem right label Jan 21, 2020
@eddex
Copy link
Owner

eddex commented Jan 21, 2020

We have a CONTRIBUTING.md now :) please read

@randombenj
Copy link
Author

Please fix the formating of the json output of the python script first :)

@eddex
Copy link
Owner

eddex commented Jan 22, 2020

The json files are formatted correctly by the script. Your branch is 37 commits behind, please update your branch.

@Lextum
Copy link
Collaborator

Lextum commented Jan 27, 2020

both modules where added with 281417b

@Lextum Lextum closed this Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@randombenj @eddex @Lextum