Revising The Twitter Badge #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more info, check [this](badges/shields#8837)
|
Hi all, request an update on this PR |
StarKnightt
reviewed
Apr 2, 2023
There was a problem hiding this comment.
In my view, there are no evident problems.
The code generates two badges for Eddie Jaoude's Twitter account and the EddieHub Discord server using the Shields.io service. These badges give a visual depiction of how many people have joined the Discord server and how many people have followed you.
However, it is vital to note that badges like these sometimes cause page load times to increase, therefore it is crucial to use them sparingly and only when they offer users useful information. Making ensuring the badge URLs are legitimate and link to the proper sites is also a good idea.
eddiejaoude
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more info, check this