release/v0.5 #23
Merged
release/v0.5 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add initial dep's: reactotron, react-native-dotenv, apisauce
- add global appConfig; - add reactotron service; - add env configs; - add babelrc; - add reactotron support;
- add api service class; - add api configs;
- refactor api & app configs; - add iexcloud api endpoints and configurations
- refactor reactotron class;
- refactor Api service to class;
- add dep react-devtools support; - update prettier config;
- add iexcloud service for better api abstraction; - remove explicit url declarations from Api class; - add response data validations to api class;
- add initial readme; - update config to disable yellowbox warnings;
- update iexcloud url endpoint for getQuote; - add additional validation params for Api.getQuote method; - update docblocs;
- add lodash, victory-native, rn router flux, rn navigation, rn toast, native-base & ui kitten libs;
- add eva-design theme configs & eva icons;
- add initial RNRF functionality; - add Bottom nav components; - add additional dummy screens; add watchlist functionality (WIP); - add initial Watchlist container & components; add chart functionality (WIP); - add initial Stock container & stock chart component;
- update babel, gitignore & prettier;
- update env file with env.example & remove .env from worktree;
- add custom dark theme;
- remove ignite & eva-design dependencies;
- refactor root navigation for better maintainability; - remove ui-kitten bottom nav; - integrate rnrf dynamic tabbed navigation;
- remove ui kitten dependencies from components;
- remove ui kitten dependencies from screens; - add dummy screens for navigation testing; - add a pretty cool duck; - add dummy watchlist data;
- update root navigation;
- remove react-toast-native; - add inapp browser display support;
- add splash lightbox screens; - add sociallinks component; - update theme variables;
- update docblocks; - add response validation to api.getLogo method;
- update api methods; - update iexcloud service; - add errorHandler service with toast notifications; - add support for moment; - add date formatting utils;
- add chart display functionality; - add chart display by range functionality; - update theme to support charts;
- cleanup app.js;
- refactor screens directory architecture;
- update welcome screen and add navigation button;
- add update intervals to quote data; - add quote data to stock view; - update styling; - add hack to cope with RN warning when due to native timeout conflicts; - add loading screen;
- add friction and tension props to SwipeableList component;
- fix issue where watchlists & watchlist symbols weren't being deleted properly;
- fix issue where reactotron was causing crashes in release versions on hardware devices;
- update code formatting & cleanup imports;
- update android release configs;
- add watchlist charts;
- fix container scroll on watchlist symbol list; - fix issue with watchlist symbols not deleting; - add abilility to add to watchlist from search; - update watchlists to toggle addSymbol to watchlist;
- code cleanup;
- updated readme;
- update readme;
…httrader into develop
- add stock news tab functionality; - add scrollable tabsBar component with top view offset; - add stock news actions & reducer logic; - add new api methods for fetching news data; - add new iexcloud service method for fetching news data; - add react prop.types support; - add dummy tabs for stock fundamentals & profile; - code cleanup;
MicheleCimminoLD
suggested changes
Nov 6, 2019
| @@ -0,0 +1,7 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
I usually configure it using husky with a pre-commit hook
| import { StatusBar } from 'react-native'; | ||
| import { RootNavigator } from './navigation/RootNavigator'; | ||
|
|
||
| const App = () => { |
There was a problem hiding this comment.
const App = () => ()
() is shortcut for return
- update lodash imports to use named functions instead of entire lib; - update inline functions to use handlers for Autocomplete props; - update some functions to destructure arguments; - refactor useSelector to only use watchlist symbols instead of entire watchlist state; - remove inline styles & refactor styles names for semantic accuracy;
- fix StockQuote styles; - refactor _renderQuoteChangeIcon function to a variable declaration; - add loading spinner until latestPrice is rendered #10;
- refactor range constants; - refactor Stock components & implement obj destructuring; - fix issue with chart dates not displaying on X axis properly; - update all lodash imports to use named imports;
| renderTextInput={_renderInput} | ||
| defaultValue={query} | ||
| hideResults={handleHideResults} | ||
| onChangeText={handleSearch} |
There was a problem hiding this comment.
debounce the onChnageInput event.If,for example the user type fast abbv,he is instered to see just the result starts with abbv and with this we avoid to make to useless http request.Use debounce from lodash
There was a problem hiding this comment.
This was already identified as a future enhancement in an existing issue #8
| const { symbol, companyName } = result; | ||
|
|
||
| return ( | ||
| <ListItem key={symbol} onPress={() => handleSelectItem(symbol)}> |
There was a problem hiding this comment.
Keys should be stable, predictable, and unique.you can't set like key something which is randomly generated.is not 100% that is unique everytime.If keys are not unique, can have an impact on performance.
There was a problem hiding this comment.
the symbol property is always unique. No two results returned from search would ever have the same symbol. The alternative is to use the array index but that would be very unstable as the array index would change any time state.results is updated - which I think would happen anytime the query changes.
This was referenced Nov 7, 2019
- fix sticky tab style issues;
- fix redundant autosearch hide item logic;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.