Merge branch '3.1.x'

Closes spring-projectsgh-37884
eddumelendez · Oct 13, 2023 · 085e12a · 085e12a
2 parents 60f05ea + 0c1b5d1
commit 085e12a
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/...ect/spring-boot/src/main/java/org/springframework/boot/web/servlet/WebServletHandler.java b/...ect/spring-boot/src/main/java/org/springframework/boot/web/servlet/WebServletHandler.java
@@ -59,14 +59,18 @@ private String determineName(Map<String, Object> attributes, BeanDefinition bean
 				: beanDefinition.getBeanClassName());
 	}
 
-	private MultipartConfigElement determineMultipartConfig(AnnotatedBeanDefinition beanDefinition) {
+	private BeanDefinition determineMultipartConfig(AnnotatedBeanDefinition beanDefinition) {
 		Map<String, Object> attributes = beanDefinition.getMetadata()
 			.getAnnotationAttributes(MultipartConfig.class.getName());
 		if (attributes == null) {
 			return null;
 		}
-		return new MultipartConfigElement((String) attributes.get("location"), (Long) attributes.get("maxFileSize"),
-				(Long) attributes.get("maxRequestSize"), (Integer) attributes.get("fileSizeThreshold"));
+		BeanDefinitionBuilder builder = BeanDefinitionBuilder.rootBeanDefinition(MultipartConfigElement.class);
+		builder.addConstructorArgValue(attributes.get("location"));
+		builder.addConstructorArgValue(attributes.get("maxFileSize"));
+		builder.addConstructorArgValue(attributes.get("maxRequestSize"));
+		builder.addConstructorArgValue(attributes.get("fileSizeThreshold"));
+		return builder.getBeanDefinition();
 	}
 
 }
diff --git a/...rc/test/java/org/springframework/boot/web/servlet/ServletComponentScanRegistrarTests.java b/...rc/test/java/org/springframework/boot/web/servlet/ServletComponentScanRegistrarTests.java
@@ -39,6 +39,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
+import static org.assertj.core.api.Assertions.assertThatNoException;
 
 /**
  * Tests for {@link ServletComponentScanRegistrar}
@@ -158,6 +159,16 @@ void processAheadOfTimeRegistersReflectionHintsForWebListeners() {
 			.accepts(generationContext.getRuntimeHints());
 	}
 
+	@Test
+	void processAheadOfTimeSucceedsForWebServletWithMultipartConfig() {
+		AnnotationConfigServletWebServerApplicationContext context = new AnnotationConfigServletWebServerApplicationContext();
+		context.registerBean(ScanServletPackage.class);
+		TestGenerationContext generationContext = new TestGenerationContext(
+				ClassName.get(getClass().getPackageName(), "TestTarget"));
+		assertThatNoException()
+			.isThrownBy(() -> new ApplicationContextAotGenerator().processAheadOfTime(context, generationContext));
+	}
+
 	@SuppressWarnings("unchecked")
 	private void compile(GenericApplicationContext context, Consumer<GenericApplicationContext> freshContext) {
 		TestGenerationContext generationContext = new TestGenerationContext(
@@ -215,4 +226,10 @@ static class ScanListenerPackage {
 
 	}
 
+	@Configuration(proxyBeanMethods = false)
+	@ServletComponentScan("org.springframework.boot.web.servlet.testcomponents.servlet")
+	static class ScanServletPackage {
+
+	}
+
 }