New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: simplify threaded Android tests #104

Merged

edeckers merged 18 commits into develop from elydeckers/feature/simplify-threaded-tests

Jan 2, 2021

Owner

edeckers commented Dec 31, 2020 •

edited

Loading

Progress

Add tests suites and categories
Migrate to coroutines
Fix broken assertion in assert_missing_required_upload_parameter_rejects_promise
Simplify re-used / boilerplate coroutine code
Simplify instrumented threaded tests
~~Use kotlinx-coroutines dependency only for testing~~ actually replaced threading with coroutine
Add logging to Kotlin code
Make test settings configurable through environment variables
Only run CI test suite

edeckers added 2 commits

December 31, 2020 01:50


          improvement: introduce test categories

15c1d3f


          improvement: rewrite threaded tests to coroutines

6e7c3c5

edeckers added the enhancement label

edeckers added this to the 1.0.7 milestone

edeckers self-assigned this

This comment has been minimized.

Sign in to view

edeckers added 2 commits

December 31, 2020 14:25


          fix: wrong EndToEndSuite category

f68ca66


          refactor: move fold outside withTimeout

36cef15

This comment has been minimized.

Sign in to view


          refactor: simplify tests a little more

f1db670

edeckers force-pushed the elydeckers/feature/simplify-threaded-tests branch from 52356a2 to f1db670 Compare

December 31, 2020 13:54

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view


          improvement: add more detailed missing key error reporting

2d93c4d

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view


          refactor: rewrite withTimeout to runRequestToBoolean

3e642d9

This comment has been minimized.

Sign in to view

edeckers mentioned this pull request

Improve Android code quality #38

Closed

9 tasks

This comment has been minimized.

Sign in to view


          improvement: migrate androidTests to coroutines

af7aadf

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

edeckers added 2 commits

December 31, 2020 18:30


          fix: explicit call to enable networking in test

dfdbe37


          fix: increase androidTests timeout

81938e2

This comment has been minimized.

Sign in to view

edeckers force-pushed the elydeckers/feature/simplify-threaded-tests branch from fe121d9 to c13d836 Compare

January 2, 2021 18:59


          improvement: read test settings from env

8422b85

edeckers force-pushed the elydeckers/feature/simplify-threaded-tests branch from c13d836 to 8422b85 Compare

January 2, 2021 19:06


          refactor: restored disabled ci steps

a444337

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

edeckers force-pushed the elydeckers/feature/simplify-threaded-tests branch from 4ff6333 to 4c6fba4 Compare

January 2, 2021 20:13

edeckers marked this pull request as ready for review

January 2, 2021 20:14

This comment has been minimized.

Sign in to view


          improvement: only run single suite on build

8b70a63

edeckers force-pushed the elydeckers/feature/simplify-threaded-tests branch from 4c6fba4 to 8b70a63 Compare

January 2, 2021 20:21

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

edeckers merged commit 455d485 into develop

edeckers deleted the elydeckers/feature/simplify-threaded-tests branch

January 2, 2021 20:57

edeckers added this to Done in Planned

Contributor

github-actions bot commented Jan 2, 2021

TypeScript Test Report

  1 files ±0   1 suites ±0 3s ⏱️ ±0s
31 tests ±0 31 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 455d485. ± Comparison against base commit 4951159.

Contributor

github-actions bot commented Jan 2, 2021

iOS Test Report

  1 files ±0   1 suites ±0 2m 0s ⏱️ ±0s
11 tests ±0 11 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 455d485. ± Comparison against base commit 4951159.

Contributor

github-actions bot commented Jan 2, 2021

Android Unit Test Report

  1 files ±0   1 suites ±0 10s ⏱️ ±0s
17 tests ±0 17 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 455d485. ± Comparison against base commit 4951159.

Contributor

github-actions bot commented Jan 2, 2021

Android Instrumented Test Report

1 files ±0 1 suites ±0 1m 42s ⏱️ + 1m 12s
6 tests ±0 6 ✔️ +4 0 💤 - 4 0 ❌ ±0

Results for commit 455d485. ± Comparison against base commit 4951159.

edeckers mentioned this pull request

I used React Native Navigation to have a kotlin Version conflict in this library. The following error occurred #106

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment