Update alloc usage to support latest nightly; work around check in llvm that broke x86 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vm that broke x86. %eip => 8 just avoids a check LLVM was making that balked with "register %eip is only available in 64-bit mode"
|
If I could possibly also ask that a new crate version could be published? I'd like to publish a crate dependent on this and it would be nice to not have to mirror it. |
|
It seems that it has been fixed (the usage of %eip) in upstream llvm: llvm-mirror/llvm@b9c9629. But I don't think that rust nightly has backported this change. EDIT: It seems that the change has been back-ported into the 7.0 release. So rust-nightly will eventually pick it up. |
|
This is now fixed upstream so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%eip => 8 just avoids a check LLVM was making during parsing that balked with "register %eip is only available in 64-bit mode": https://github.com/llvm-mirror/llvm/blob/7ead4232dac43866b3aa2b39aa787823654f4f36/lib/Target/X86/AsmParser/X86AsmParser.cpp#L1102