X86_64 Windows Support And Ergonomic Context Wrapper #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds easy support for x86_64 Windows. It uses the standard heap allocator for stack allocation, which requires stdlib.
This adds an ergonomic wrapper for Context, which uses an OsStack type stack. I was unable to make it generic across all stack types, but this does provide some nice usage. It also supports terminating and prevents the fiber/thread from being run once it has terminated, and returns a value indicating if it has terminated.
mark3982
changed the title
|
I have made usage more ergonomic, at least when using a Context based on the OsStack. This implementation is named OsFiber and is only enabled on Windows. It provides an easy way to spawn fibers and then detect when they are finished. It also prevents a finished fiber from being run again which would lead to a crash. |
|
Welp — sorry for not seeing this! I'd like to review this, could you rebase it onto the current master? |
edef1c
force-pushed
the
master
branch
2 times, most recently
from
f45bc47
to
591b4d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it may be desirable to use direct memory page allocation for Windows, but this was the easiest and fastest way to get support working. If you do not merge it then maybe you can at least see what needs to be done in order to support Windows.