Errors at build step: unknown: Cannot read property 'add' of undefined while minifying [...]

[lvanbever]

Hi Eric,

I'm getting the following stack trace when trying to mup deploy the latest commit. Any idea what could be the root cause?

Thanks!
Laurent

Building the application
Errors prevented bundling:
While minifying app code:

/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/babel-plugin-minify-mangle-names/lib/scope-tracker.js:47:34:
unknown: Cannot read property 'add' of undefined while minifying dynamic/node_modules/pdfjs-dist/build/pdf.js
at ScopeTracker.addReference
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/babel-plugin-minify-mangle-names/lib/scope-tracker.js:47:34)
at ReferencedIdentifier
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/babel-plugin-minify-mangle-names/lib/index.js:196:26)
at newFn
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/visitors.js:220:17)
at bfsTraverse
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/babel-plugin-minify-mangle-names/lib/bfs-traverse.js:32:43)
at Mangler.collect
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/babel-plugin-minify-mangle-names/lib/index.js:229:7)
at Mangler.run
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/babel-plugin-minify-mangle-names/lib/index.js:54:12)
at PluginPass.exit
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/babel-plugin-minify-mangle-names/lib/index.js:558:19)
at newFn
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/visitors.js:179:21)
at NodePath._call
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/path/context.js:55:20)
at NodePath.call
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/path/context.js:42:17)
at NodePath.visit
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/path/context.js:99:8)
at TraversalContext.visitQueue
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/context.js:112:16)
at TraversalContext.visitSingle
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/context.js:84:19)
at TraversalContext.visit
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/context.js:140:19)
at Function.traverse.node
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/index.js:84:17)
at traverse
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/index.js:66:12)
at transformFile
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/core/lib/transformation/index.js:107:29)
at transformFile.next (<anonymous>)

[...]

While minifying app code:
<anonymous>: unknown: Maximum call stack size exceeded while minifying packages/modules.js
at String.split (<anonymous>)
at NodePath.get
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/path/family.js:167:21)
at NodePath._resolve
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/path/introspection.js:320:14)
at NodePath.resolve
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/path/introspection.js:311:15)
at
/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/traverse/lib/path/inference/inferer-reference.js:62:27
at Array.filter (<anonymous>)

[...]

at Object.minify
(/local/home/vlaurent/.meteor/packages/zodern_standard-minifier-js/.4.0.0.sguz8b.1thzr++os+web.browser+web.browser.legacy+web.cordova/plugin.fastMinifier.os/npm/node_modules/meteor/babel-compiler/node_modules/meteor-babel/index.js:183:33)
at Object.minify (packages/babel-compiler.js:59:29)
at meteorJsMinify (packages/zodern_minifier-js.js:70:29)
at MeteorBabelMinifier.minifyOneFile (packages/fastMinifier/plugin/minify-js.js:31:12)
at packages/zodern:caching-minifier/caching-minifier.js:59:23
at Function.Profile.time (packages/zodern:caching-minifier/caching-minifier.js:14:5)
at MeteorBabelMinifier.minifyFile (packages/zodern:caching-minifier/caching-minifier.js:58:15)
at packages/fastMinifier/plugin/minify-js.js:167:27
at Function.Profile.time (packages/fastMinifier/plugin/minify-js.js:12:5)
at packages/fastMinifier/plugin/minify-js.js:166:17
at Array.forEach (<anonymous>)
at MeteorBabelMinifier.<anonymous> (packages/fastMinifier/plugin/minify-js.js:147:9)
at MeteorBabelMinifier.processFilesForBundle (packages/fastMinifier/plugin/minify-js.js:8:19)

[edemaine]

I haven't seen that before. I assume you ran npm install? Maybe try deleting node_modules/pdfjs-dist and running npm install again, just to make sure it's not a broken install?

What operating system are you using?

It seems like this might be the issue: babel/minify#974
Unfortunately, Coauthor doesn't have an explicit @babel/core dependency; I believe it's from here.

[lvanbever]

Indeed, I run npm install. Unfortunately, the fresh install didn't solve the problem (deleting node_modules/ + cache clean).

I'm running Ubuntu 18.04.5 LTS. Running Meteor 1.11.1, npm 6.14.15, node v16.8.0, and mup 1.5.3 as of now.

Looks indeed like the same bug I'm running into. The fix is somehow unclear to me though given that the wiping out didn't do the trick.

FYI, I also tried a fresh re-install of coauthor on a new ubuntu VM and also run into the same problem.

[edemaine]

I just tested on Ubuntu 16.04.7 LTS, Meteor 1.11.1, npm 6.14.8 (what's available via meteor npm), node v12.13.1, mup 1.5.3 from a fresh clone, and mup deploy worked fine. Weird. Maybe it's worth posting your package-lock.json (e.g. via gist) and I can compare?

Does meteor build test-build similarly crash?

[edemaine]

Can you try changing the relevant line of package.json to "pdfjs-dist": "2.5.207" (remove the ^)?

[lvanbever]

This also solved the issue on our production VM! Thanks again. Happy the fix was a simple one in the end.

[edemaine]

Thanks for the testing! I've put this change in master. It's annoying that we can't upgrade pdfjs, but probably fine for now (until Babel gets fixed).

[lvanbever]

Wow!! The "pdfjs-dist": "2.5.207" seems to have done the trick 🥇 😃 (it successfully builds on my test VM). I'll try it on our production VM (which exhibits the same error) first thing tomorrow morning.

Thanks for the fast support!