Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condense editor list #393

Closed
edemaine opened this issue Apr 29, 2019 · 1 comment
Closed

Condense editor list #393

edemaine opened this issue Apr 29, 2019 · 1 comment

Comments

@edemaine
Copy link
Owner

edemaine commented Apr 29, 2019 •
edited

Instead of "created by Erik Demaine at ..., last edited by Erik Demaine at ..." we really want:

  • By: List of all authors, ordered by first edit time (so first = creator)
  • Last updated: Overall last edited date (not by user)
  • Created: too?
  • (optional) Hover on author -> their last edit time

[Jeffrey]
@edemaine edemaine mentioned this issue Jan 17, 2021
Open
37 tasks
@edemaine
Copy link
Owner Author

Done in WIP verison of #503.

edemaine added a commit that referenced this issue Jan 21, 2021
@edemaine
Authorship & Access List major revamp (#503)
4ed4aca 
See #503 for lots about the new model: coauthors (vs. authors = actual
edits to the message) and access list replacing @mention permission.

Client: lots of changes especially when editing
* BelowEditor shows Coauthors always, and Access in private messages
  (and messages that somehow have Access set, e.g. formerly private)
* Input via react-bootstrap-typeahead
* History view shows authors that aren't coauthors (via 'also')
* Access shows suggestions for @mentions
* Reply All from private messages inherit accessibility from parent
* Action / Coauthor for quick way to add yourself as a coauthor
* More compact MessageAuthor formatting (fix #393)
* `text-help` class to indicate hoverable help

Lib: revamped permissions
* @mentions no longer grant any permissions (but bootstrap old data)
  -- no more regular expressions in standard queries!
* Coauthorship grants explicit read/write access in all cases
* Access list grants explicit read access if published and not deleted
* Fix `addRootsToQuery` to not add roots that the user didn't have
  access to (known but forgotten permissions bug), by $and'ing on
  permission query again.  We really only needed this when accessing
  the global group (which we now do via `maybeAddRootsToQuery`),
  so not a big performance impact most of the time.
* Live view now works in global group
* Fix `canEdit` to check visibility of message too; before, you could
  edit a message if you knew its ID even if it was e.g. private
  (and you had group-wide edit permission).  This would make you an
  author, which would let you see secret messages given their IDs.
* messageNew now correctly fails if specified parent doesn't exist.
* Notifications for changes to coauthors and access
* Import bug fix and support for `coauthors`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edemaine