Add canUpdate as invariant #188 #189 #190 #192

[valentinbujdoso]

#188
#189
#190
#192

[valentinbujdoso]

@magwas If I dont give a static value or set it somewhere the sonarcloud will fail.
What should I do? As I understand we does not use it anywhere yet.

[magwas]

I told Sonar not to whine about pubic properties of an Entity.
This is due to the fact that we go with Uncle Bob's suggestion that you should separate data and behaviour, and in this case you can have public properites, no need for getters and setters. However Sonar is an oldschool chap, who does not know this distinction.

[magwas]

You are revoking a test here. don't do that.
Just add the new behaviour (I hope the analysis script can cope with that. If not, then it will be fixed.)

[valentinbujdoso]

I can not leave two tested_behaviour here :(
So should I create a separate test for it?

[magwas]

thanks for the cleanup

[magwas]

testcasecount=3

[valentinbujdoso]

Are you sure about the 3 testcase? :)

[magwas]

what is your count?

[valentinbujdoso]

src/test/java/org/rulez/demokracia/pdengine/ObtainBallotInvariantsTest.java
src/test/java/org/rulez/demokracia/pdengine/VoteInitialValuesTest.java
src/test/java/org/rulez/demokracia/pdengine/VoteSetParametersTest.java
src/test/java/org/rulez/demokracia/pdengine/VoteModificationInvariantsObservedTest.java
1 tests in every files, but the last one is only 1 row without the good behaviour. (Duplicated behaviour problem)

[magwas]

Well, I did not count VoteModificationInvariantsObservedTest.java, as it is not a new test, and does not have the behaviour recorded.
You can reopen and fix it, even by just inserting that annotation on the top as well. Sooner or later I will have to check whether more behaviour annotations are handled by zenta-tools anyway...