[Feat] Deepgram TTS #191
Merged
[Feat] Deepgram TTS #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DninoAdnane
reviewed
Apr 26, 2024
DninoAdnane
reviewed
Apr 29, 2024
| @@ -206,7 +206,7 @@ def audio__text_to_speech( | |||
| if audio_format: | |||
| base_url += f"&container={audio_format}" | |||
|
|
|||
| if sampling_rate or sampling_rate != 0: | |||
| if sampling_rate and sampling_rate != 0: | |||
There was a problem hiding this comment.
sorry to be samet :(
we can actually than just write:
if sampling_rate:There was a problem hiding this comment.
0 is not accepted and it will return an error (if the user send 0 or None than it should ignore the sampling_rate)
There was a problem hiding this comment.
Yes, with the condition if sampling_rate he will automatically not enter the if condition (0 is considered as False also)
DninoAdnane
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.