Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YunusAndreasson/issue2209 #2223

Merged
merged 2 commits into from
Aug 6, 2023
Merged

YunusAndreasson/issue2209 #2223

merged 2 commits into from
Aug 6, 2023

Conversation

YunusAndreasson
Copy link
Member

Fixes #2217 #2209

Signed-off-by: Yunus Andréasson yunus@edenmind.com

Pull Request

Checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

Make sure that the Pull Request:

  • Meets the Definition of Done.
  • Includes tests for any new functionality.
  • Has been tested for backwards compatibility.
  • Version number has been bumped.

Jazāk Allāhu Khayran!

Fixes #2217 #2209

Signed-off-by: Yunus Andréasson <yunus@edenmind.com>
Fixes #2217 #2209

Signed-off-by: Yunus Andréasson <yunus@edenmind.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

  • api/package.json
  • mobile/package.json
  • web/package.json

@YunusAndreasson YunusAndreasson merged commit bfccf61 into main Aug 6, 2023
7 of 8 checks passed
@YunusAndreasson YunusAndreasson deleted the YunusAndreasson/issue2209 branch August 6, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Play the sentence after practicing a word in quiz mode
1 participant