Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: amazon S3 #277

Merged
merged 2 commits into from
Oct 7, 2019
Merged

add: amazon S3 #277

merged 2 commits into from
Oct 7, 2019

Conversation

romain-dartigues
Copy link
Collaborator

From the 2018.02.22 icons pack; don't know if you prefer the 2019 "flat" versions (check https://aws.amazon.com/architecture/icons/).

From the 2018.02.22 icons pack.
@romain-dartigues romain-dartigues mentioned this pull request Oct 7, 2019
5 tasks
@edent
Copy link
Owner

edent commented Oct 7, 2019

You can save a few bytes by removing newlines.

@edent edent merged commit 94a5eae into edent:master Oct 7, 2019
@edent
Copy link
Owner

edent commented Oct 7, 2019

I'm granting you commit access to the Repo. This is per the advice of The Pull Request Hack.

Please use this privileged wisely.

@romain-dartigues
Copy link
Collaborator Author

Thank you a lot for the privilege! \o/

I'll push in distinct branches on your repo and ask for review for the first few... Do not hesitate to edit/rework my commit to show me what you would expect.

You can save a few bytes by removing newlines.
Hum, could you give me an example? I thought you wanted to keep newlines because "This makes viewing diffs easier"?

@romain-dartigues romain-dartigues deleted the add-amazon-s3 branch October 7, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants