Add Protonmail #278
Merged
Add Protonmail #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's mindblowing how fast you are! |
edent
reviewed
Oct 8, 2019
There was a problem hiding this comment.
I think it's required to have rounded corners to keep the look with the others icons; how about:
<svg
xmlns="http://www.w3.org/2000/svg"
aria-label="Protonmail"
fill="#fff"
viewBox="0 0 512 512"><rect
width="512" height="512"
rx="15%"
fill="#8A90C7"/><path d="M259 77s-108-6-131 114v79s0 12 23 29c28 17 91 68 108 68s74-51 102-69c23-16 23-28 23-28v-79C361 71 259 77 259 77zm68 159H185v-45c11-57 74-57 74-57s57 0 68 57v45z"/><path d="M259 384l-34-12-97-68v120s0 11 17 11h222c11 0 17-11 17-11V304l-97 69-28 11z"/></svg>
images/svg/protonmail.svg
Outdated
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| aria-label="Protonmail" | ||
| viewBox="0 0 512 512"> |
There was a problem hiding this comment.
You could save over 20 bytes by removing the spaces, the group and putting the fill=... into the <svg tag.
Also, I think it would require the white background rectangle.
There was a problem hiding this comment.
Is it a white background rectangle with a color circle (rounded rect) on top? In that case, I can knock the paths out of the circle if that ends up being smaller.
|
Yup - if you can make those small changes, we can merge it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #265